Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse views and materialized views from Hive #746

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

Apache Hive also has views and materialized views.

🤓 What?

  • Added logic for parsing Hive views and materialized views as datasets.
  • Added unit test.

🧪 Tested?

  • Added unit test.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

This pull request has been linked to Shortcut Story #23516: Hive crawler: views & materialized views.

Copy link

github-actions bot commented Jan 8, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
15343 14146 92% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/hive/extractor.py 99% 🟢
TOTAL 99% 🟢

updated for commit: b1d24ca by action🐍

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6aed3d7) 91.98% compared to head (43cdc18) 92.19%.
Report is 2 commits behind head on main.

❗ Current head 43cdc18 differs from pull request most recent head b1d24ca. Consider uploading reports for the commit b1d24ca to get more accurate results

Files Patch % Lines
metaphor/hive/config.py 88.88% 2 Missing ⚠️
metaphor/hive/extractor.py 98.57% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   91.98%   92.19%   +0.20%     
==========================================
  Files         182      147      -35     
  Lines       15403    15343      -60     
==========================================
- Hits        14169    14146      -23     
+ Misses       1234     1197      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metaphor/hive/extractor.py Outdated Show resolved Hide resolved
@usefulalgorithm usefulalgorithm enabled auto-merge (squash) January 8, 2024 14:55
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

metaphor/hive/extractor.py Show resolved Hide resolved
@usefulalgorithm usefulalgorithm merged commit 1b8b14f into main Jan 8, 2024
4 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-23516/hive-crawler-views-materialized-views branch January 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants