Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #745

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Update README.md #745

merged 4 commits into from
Jan 8, 2024

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Jan 7, 2024

🤓 What?

Improve the README file for Kafka.

@mars-lan mars-lan enabled auto-merge (squash) January 7, 2024 01:57
Copy link

github-actions bot commented Jan 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
15333 14136 92% 85% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: d987bd4 by action🐍

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6aed3d7) 91.98% compared to head (d987bd4) 92.19%.
Report is 1 commits behind head on main.

Files Patch % Lines
metaphor/hive/config.py 88.88% 2 Missing ⚠️
metaphor/hive/extractor.py 98.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   91.98%   92.19%   +0.20%     
==========================================
  Files         182      147      -35     
  Lines       15403    15333      -70     
==========================================
- Hits        14169    14136      -33     
+ Misses       1234     1197      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

usefulalgorithm
usefulalgorithm previously approved these changes Jan 8, 2024
Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clicked wrong, I meant to click comment XD

metaphor/kafka/README.md Outdated Show resolved Hide resolved
metaphor/kafka/README.md Show resolved Hide resolved
metaphor/kafka/README.md Outdated Show resolved Hide resolved
metaphor/kafka/README.md Show resolved Hide resolved
mars-lan and others added 2 commits January 8, 2024 05:53
Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mars-lan mars-lan merged commit 2653602 into main Jan 8, 2024
6 checks passed
@mars-lan mars-lan deleted the mars-lan-patch-1 branch January 8, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants