-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crawler should generate run metadata if output is valid #724
Crawler should generate run metadata if output is valid #724
Conversation
This pull request has been linked to Shortcut Story #22889: Not all crawler fail generate run metadata. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
+ Coverage 91.21% 91.89% +0.68%
==========================================
Files 172 137 -35
Lines 14486 14416 -70
==========================================
+ Hits 13213 13248 +35
+ Misses 1273 1168 -105 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring!
🤔 Why?
We are not generating the
run.metadata
file if there is an error in__init__
or the config file is not valid.🤓 What?
run_connector
.BaseConfig
in thecli_main
so that we can write the run metadata even it's an invalid config file.platform
anddescription
out of__init__
, and define the two as class variables.🧪 Tested?
☑️ Checks
pyproject.toml
.