Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pydnatic email extra #641

Merged

Conversation

mars-lan
Copy link
Contributor

🤔 Why?

Power BI connector is throwing the following error:

2023-10-19 19:03:54:ERROR:metaphor:email-validator is not installed, run `pip install pydantic[email]`
Traceback (most recent call last):
  File "pydantic/networks.py", line 578, in pydantic.networks.import_email_validator
ModuleNotFoundError: No module named 'email_validator'

🤓 What?

As titled.

🧪 Tested?

Verified against a production instance.

@mars-lan mars-lan requested review from alyiwang and elic-eon October 19, 2023 22:22
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #21741: Power BI missing email-validator dependency.

@mars-lan mars-lan enabled auto-merge (squash) October 19, 2023 22:24
@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12724 11508 90% 85% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: cd8d5de by action🐍

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 31 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@mars-lan mars-lan merged commit 4d9c518 into main Oct 19, 2023
@mars-lan mars-lan deleted the marslan/sc-21741/power-bi-missing-email-validator-dependency branch October 19, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants