Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract refresh schedule #636

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Oct 18, 2023

🤔 Why?

Get refresh schedule information for PowerBI Dataset

🤓 What?

🧪 Tested?

Test the crawler against testing and production environment.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #20848: Get PowerBI refresh metadata.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12690 11481 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/power_bi/extractor.py 91% 🟢
metaphor/power_bi/power_bi_client.py 83% 🟢
TOTAL 87% 🟢

updated for commit: 2d1413e by action🐍

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
metaphor/power_bi/extractor.py 90.84% <92.30%> (+0.06%) ⬆️
metaphor/power_bi/power_bi_client.py 82.76% <91.66%> (+0.67%) ⬆️

... and 31 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@elic-eon elic-eon marked this pull request as ready for review October 19, 2023 07:13
@elic-eon elic-eon enabled auto-merge (squash) October 19, 2023 07:25
@elic-eon elic-eon requested review from mars-lan and alyiwang October 19, 2023 07:25
@mars-lan
Copy link
Contributor

Test failed?

@elic-eon
Copy link
Contributor Author

Test failed?

Patch line must above 80%?

@elic-eon elic-eon requested a review from mars-lan October 19, 2023 17:00
@elic-eon elic-eon merged commit 2f3b0d4 into main Oct 19, 2023
6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-20848/get-powerbi-refresh-metadata branch October 19, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants