Pin oscrypto to specific hash to fix compatiblity issue with OpenSSL #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #21474: Snowflake crawlers failing due to libcrypto version detection. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Codecov ReportAll modified lines are covered by tests ✅ see 31 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
elic-eon
approved these changes
Oct 11, 2023
mars-lan
deleted the
marslan/sc-21474/snowflake-crawlers-failing-due-to-libcrypto
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
#624 didn't fix the issue. As explained here, it's a compatibility issue between
oscrypto& newer version ofOpenSSL.🤓 What?
While the issue has been fixed upstream, no new version has been released on PyPI yet. Pinning down the version for now as suggested in wbond/oscrypto#78
🧪 Tested?
Verified against a production instance.