Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quicksight rate limiting [sc-30089] #1061

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

alyiwang
Copy link
Contributor

🤔 Why?

The QuickSight API can hang sometimes, possibly due to rate limit.

🤓 What?

  • Add a function wrapper around the API to timeout and retry

🧪 Tested?

tested on Metaphor instance, will test on customer env.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@alyiwang alyiwang requested a review from mars-lan January 10, 2025 21:06
@alyiwang alyiwang enabled auto-merge (squash) January 10, 2025 21:07
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13542 12124 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/quick_sight/client.py 82% 🟢
TOTAL 82% 🟢

updated for commit: 0dbe975 by action🐍

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.52%. Comparing base (8384d2c) to head (0dbe975).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/quick_sight/client.py 78.78% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1061      +/-   ##
==========================================
- Coverage   89.55%   89.52%   -0.03%     
==========================================
  Files         210      210              
  Lines       13513    13542      +29     
==========================================
+ Hits        12102    12124      +22     
- Misses       1411     1418       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyiwang alyiwang merged commit 4570c30 into main Jan 10, 2025
4 of 6 checks passed
@alyiwang alyiwang deleted the yi.wang/sc-30089/quicksight-rate-limiting branch January 10, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants