Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safe date parsing in Monte Carlo connector #1057

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Jan 6, 2025

🤔 Why?

prevExecutionTime returned by getMonitors can be null and must be handled gracefully.

🤓 What?

As titled. Also defensively applied the same tocreatedTime from getAlerts.

🧪 Tested?

Verified against a production instance.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@mars-lan mars-lan requested a review from alyiwang January 6, 2025 19:35
@mars-lan mars-lan enabled auto-merge (squash) January 6, 2025 19:35
Copy link

github-actions bot commented Jan 6, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13526 12124 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/monte_carlo/extractor.py 90% 🟢
TOTAL 90% 🟢

updated for commit: dba0776 by action🐍

@mars-lan mars-lan merged commit 832794e into main Jan 6, 2025
3 of 4 checks passed
@mars-lan mars-lan deleted the marslan/sc-30066/mc-alerts-parsing-error branch January 6, 2025 20:10
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (8a75908) to head (dba0776).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         210      210           
  Lines       13526    13526           
=======================================
  Hits        12124    12124           
  Misses       1402     1402           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants