Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to Monte Carlo getMonitors call #1050

Merged

Conversation

mars-lan
Copy link
Contributor

🤔 Why?

MC's GraphQL API places limit the max response size to 6 MB. The current non-paginated getMonitors call can exceed that limit when is a large number monitors configured.

🤓 What?

As titled.

🧪 Tested?

Verified that before & after output are identical against a production instance.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@mars-lan mars-lan requested review from alyiwang and rishimo December 20, 2024 22:00
@mars-lan mars-lan enabled auto-merge (squash) December 20, 2024 22:00
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13481 12070 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/monte_carlo/extractor.py 89% 🟢
TOTAL 89% 🟢

updated for commit: b43330d by action🐍

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.53%. Comparing base (9f01e66) to head (b43330d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/monte_carlo/extractor.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
+ Coverage   89.51%   89.53%   +0.01%     
==========================================
  Files         211      211              
  Lines       13478    13481       +3     
==========================================
+ Hits        12065    12070       +5     
+ Misses       1413     1411       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alyiwang alyiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mars-lan mars-lan merged commit 9b2b596 into main Dec 23, 2024
6 checks passed
@mars-lan mars-lan deleted the marslan/sc-30031/add-pagination-to-mc-getmonitors-call branch December 23, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants