Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snowflake source info last updated missing [sc-29859] #1048

Merged

Conversation

alyiwang
Copy link
Contributor

@alyiwang alyiwang commented Dec 3, 2024

🤔 Why?

get_ddl function in snowflake may throw SQL compilation error in some rare cases. This will cause all the table info for all the tables in the same batch to be lost.

🤓 What?

  • split the get_ddl with get last update time, so at least they won't impact each other.

🧪 Tested?

tested against Metaphor instance

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@alyiwang alyiwang requested a review from mars-lan December 3, 2024 00:22
@alyiwang alyiwang enabled auto-merge (squash) December 3, 2024 00:22
Copy link

github-actions bot commented Dec 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13466 12053 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/snowflake/extractor.py 80% 🟢
TOTAL 80% 🟢

updated for commit: 6d3d132 by action🐍

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.50%. Comparing base (a42a0d6) to head (6d3d132).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/snowflake/extractor.py 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   89.51%   89.50%   -0.01%     
==========================================
  Files         211      211              
  Lines       13448    13466      +18     
==========================================
+ Hits        12038    12053      +15     
- Misses       1410     1413       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyiwang alyiwang merged commit e7c3ad9 into main Dec 3, 2024
6 checks passed
@alyiwang alyiwang deleted the yi.wang/sc-29859/snowflake-investigate-why-source-info-last branch December 3, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants