Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-29767] Populate TableInfo.tags #1041

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

Dataset tags should be populated into TableInfo.tags.

🤓 What?

Populate TableInfo.tags with tags gathered from SQL query.

🧪 Tested?

  • Added unit test.
  • Tested against stage configuration. Previously no tags were found, now tags are being populated properly.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13429 12020 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/unity_catalog/models.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 093d8cf by action🐍

@usefulalgorithm usefulalgorithm merged commit 66a2d3f into main Nov 12, 2024
4 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-29767/missing-uc-tags branch November 12, 2024 10:07
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (270734c) to head (093d8cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1041   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files         211      211           
  Lines       13429    13429           
=======================================
  Hits        12020    12020           
  Misses       1409     1409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants