Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-29773] Handle tables without columns #1040

Merged

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

Our crawler did not take into account for the case when row["columns"] is a None.

🤓 What?

  • Fix NoneType not iterable error
  • Refactor to make testing easier
  • Added tests

🧪 Tested?

  • Added unit test.
  • Tested against stage environment.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Nov 12, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13429 12020 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/unity_catalog/models.py 100% 🟢
metaphor/unity_catalog/queries.py 97% 🟢
TOTAL 99% 🟢

updated for commit: b7d06f5 by action🐍

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (6d6cf69) to head (b7d06f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1040   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files         211      211           
  Lines       13422    13429    +7     
=======================================
+ Hits        12013    12020    +7     
  Misses       1409     1409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@elic-eon elic-eon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usefulalgorithm usefulalgorithm merged commit 270734c into main Nov 12, 2024
6 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-29773/handle-tables-without-columns-in-uc branch November 12, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants