Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-29547] Deprecate BQ lineage crawler and a lot of refactor #1038

Conversation

usefulalgorithm
Copy link
Contributor

@usefulalgorithm usefulalgorithm commented Nov 7, 2024

🤔 Why?

We want to deprecate BQ lineage crawler.

🤓 What?

  • Removed implementation in BQ lineage crawler, and move the logic into main BQ crawler.
  • Moved a bunch of code in main BQ crawler into separate files.

🧪 Tested?

  • Run crawler against our stage configuration.
  • Updated unit tests.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Nov 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13422 12013 90% 85% 🟢

New Files

File Coverage Status
metaphor/bigquery/log_filter.py 100% 🟢
metaphor/bigquery/log_type.py 86% 🟢
metaphor/bigquery/queries.py 100% 🟢
metaphor/bigquery/schema_field.py 96% 🟢
metaphor/bigquery/table.py 96% 🟢
TOTAL 96% 🟢

Modified Files

File Coverage Status
metaphor/bigquery/config.py 100% 🟢
metaphor/bigquery/extractor.py 82% 🟢
metaphor/bigquery/lineage/extractor.py 79% 🟢
metaphor/bigquery/profile/extractor.py 61% 🟢
TOTAL 80% 🟢

updated for commit: 30d753f by action🐍

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 90.08621% with 23 lines in your changes missing coverage. Please review.

Project coverage is 89.50%. Comparing base (02f7f98) to head (30d753f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/bigquery/extractor.py 86.81% 12 Missing ⚠️
metaphor/bigquery/job_change_event.py 90.56% 5 Missing ⚠️
metaphor/bigquery/lineage/extractor.py 60.00% 2 Missing ⚠️
metaphor/bigquery/log_type.py 85.71% 1 Missing ⚠️
metaphor/bigquery/profile/extractor.py 50.00% 1 Missing ⚠️
metaphor/bigquery/schema_field.py 96.15% 1 Missing ⚠️
metaphor/bigquery/table.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   89.29%   89.50%   +0.20%     
==========================================
  Files         206      211       +5     
  Lines       13440    13422      -18     
==========================================
+ Hits        12001    12013      +12     
+ Misses       1439     1409      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usefulalgorithm usefulalgorithm marked this pull request as ready for review November 7, 2024 10:49
@usefulalgorithm usefulalgorithm enabled auto-merge (squash) November 8, 2024 06:15
Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this include the rate limit change (#1032)?

metaphor/bigquery/config.py Outdated Show resolved Hide resolved
Co-authored-by: Mars Lan <[email protected]>
@usefulalgorithm
Copy link
Contributor Author

It does

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring!

@usefulalgorithm usefulalgorithm enabled auto-merge (squash) November 9, 2024 11:08
@mars-lan mars-lan merged commit 6d6cf69 into main Nov 9, 2024
6 checks passed
@mars-lan mars-lan deleted the tsung-julii/sc-29547/merge-bigquery-lineage-into-the-base-crawler branch November 9, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants