Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill sourceInfo mainUrl for all entities #1034

Merged

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Nov 5, 2024

🤔 Why?

To show the web extension tab for entities

🤓 What?

  • Fill in sourceInfo.mainUrl as much as possible

🧪 Tested?

Unit tests

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@elic-eon elic-eon enabled auto-merge (squash) November 5, 2024 15:10
Copy link

github-actions bot commented Nov 5, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13438 11998 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/looker/lookml_parser.py 94% 🟢
metaphor/power_bi/extractor.py 89% 🟢
metaphor/tableau/extractor.py 87% 🟢
metaphor/thought_spot/extractor.py 92% 🟢
TOTAL 90% 🟢

updated for commit: 0e9cec0 by action🐍

@elic-eon elic-eon merged commit 7d4fce9 into main Nov 5, 2024
4 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-29599/fill-sourceinfo-mailurl-for-all-entities branch November 5, 2024 15:12
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.28%. Comparing base (1f045f2) to head (0e9cec0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1034   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files         206      206           
  Lines       13435    13438    +3     
=======================================
+ Hits        11995    11998    +3     
  Misses       1440     1440           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants