Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-2887] GX Crawler #1025

Merged
merged 8 commits into from
Oct 31, 2024

Conversation

usefulalgorithm
Copy link
Contributor

@usefulalgorithm usefulalgorithm commented Oct 30, 2024

🤔 Why?

Great Expectations is a well known data quality assurance tool, we want to get data monitor information from it.

🤓 What?

Implemented basic GX crawler. Currently only Snowflake and Postgres connections have been tested. Pandas datasources and simple csv files are not supported, as we can't link them to actual datasets in an existing data platform.

An ExpectationSuite is mapped to a DataMonitor, so if there's a single failed Expectation in the suite, the monitor will be marked as failed.

🧪 Tested?

Added unit tests.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Oct 30, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13382 11953 89% 85% 🟢

New Files

File Coverage Status
metaphor/great_expectations/config.py 100% 🟢
metaphor/great_expectations/extractor.py 89% 🟢
TOTAL 94% 🟢

Modified Files

File Coverage Status
metaphor/glue/extractor.py 96% 🟢
TOTAL 96% 🟢

updated for commit: 76f4a61 by action🐍

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 90.09901% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@955ff89). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/great_expectations/extractor.py 88.88% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage        ?   89.32%           
=======================================
  Files           ?      205           
  Lines           ?    13382           
  Branches        ?        0           
=======================================
  Hits            ?    11953           
  Misses          ?     1429           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metaphor/great_expectations/extractor.py Outdated Show resolved Hide resolved
metaphor/great_expectations/extractor.py Outdated Show resolved Hide resolved
Copy link
Contributor

@elic-eon elic-eon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogo

@usefulalgorithm usefulalgorithm merged commit 962839d into main Oct 31, 2024
6 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-2887/great-expectations-crawler branch October 31, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants