Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PostgreSQL usage connector #1023

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Deprecate PostgreSQL usage connector #1023

merged 4 commits into from
Oct 28, 2024

Conversation

mars-lan
Copy link
Contributor

🤔 Why?

It's no longer in use as the usage is directly derived from the query log.

🤓 What?

As titled. Also cleaned up tests & updated README.

🧪 Tested?

N/A

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@mars-lan mars-lan marked this pull request as ready for review October 28, 2024 04:56
@mars-lan mars-lan enabled auto-merge (squash) October 28, 2024 04:56
Copy link

github-actions bot commented Oct 28, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13194 11777 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/postgresql/usage/extractor.py 0% 🟢
TOTAL 0% 🟢

updated for commit: c1af938 by action🐍

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.26%. Comparing base (bc733e2) to head (c1af938).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/postgresql/usage/extractor.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
+ Coverage   89.24%   89.26%   +0.01%     
==========================================
  Files         202      202              
  Lines       13220    13194      -26     
==========================================
- Hits        11798    11777      -21     
+ Misses       1422     1417       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

metaphor/postgresql/usage/extractor.py Outdated Show resolved Hide resolved
mars-lan and others added 2 commits October 28, 2024 04:20
@mars-lan mars-lan merged commit db18615 into main Oct 28, 2024
5 of 6 checks passed
@mars-lan mars-lan deleted the postgres_usage branch October 28, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants