Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI crawler #1021

Merged
merged 22 commits into from
Oct 28, 2024
Merged

OpenAPI crawler #1021

merged 22 commits into from
Oct 28, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Oct 25, 2024

🤔 Why?

To extract endpoints from OpenAPI spec.

🤓 What?

Add openapi crawler

🧪 Tested?

Test cases and verified end-to-end on dev.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Oct 25, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13220 11798 89% 85% 🟢

New Files

File Coverage Status
metaphor/openapi/config.py 100% 🟢
metaphor/openapi/extractor.py 91% 🟢
TOTAL 96% 🟢

Modified Files

File Coverage Status
metaphor/common/event_util.py 94% 🟢
TOTAL 94% 🟢

updated for commit: fb09e48 by action🐍

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 93.27731% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.24%. Comparing base (ac2cf60) to head (fb09e48).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/openapi/extractor.py 91.30% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
+ Coverage   89.20%   89.24%   +0.03%     
==========================================
  Files         200      202       +2     
  Lines       13103    13220     +117     
==========================================
+ Hits        11689    11798     +109     
- Misses       1414     1422       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a high level. @usefulalgorithm @alyiwang pls take a closer look.

metaphor/openapi/README.md Outdated Show resolved Hide resolved
metaphor/openapi/extractor.py Outdated Show resolved Hide resolved
metaphor/openapi/extractor.py Outdated Show resolved Hide resolved
metaphor/openapi/extractor.py Show resolved Hide resolved
metaphor/openapi/extractor.py Show resolved Hide resolved
metaphor/openapi/config.py Outdated Show resolved Hide resolved
metaphor/openapi/extractor.py Outdated Show resolved Hide resolved
metaphor/openapi/extractor.py Show resolved Hide resolved
metaphor/openapi/extractor.py Outdated Show resolved Hide resolved
metaphor/openapi/extractor.py Outdated Show resolved Hide resolved
metaphor/openapi/config.py Outdated Show resolved Hide resolved
Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there...

metaphor/openapi/config.py Outdated Show resolved Hide resolved
metaphor/openapi/extractor.py Show resolved Hide resolved
metaphor/openapi/extractor.py Outdated Show resolved Hide resolved
metaphor/openapi/extractor.py Outdated Show resolved Hide resolved
metaphor/openapi/extractor.py Outdated Show resolved Hide resolved
elic-eon and others added 5 commits October 28, 2024 17:21
Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@elic-eon elic-eon merged commit bc733e2 into main Oct 28, 2024
6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-29276/crawler-for-openapi branch October 28, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants