Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redshift profiler missing tables [sc-29514] #1017

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

alyiwang
Copy link
Contributor

🤔 Why?

The include_view config was used incorrectly, doing the exact opposite.

🤓 What?

  • fix the dataset filtering based on include_view, also excluding external, stream, snapshot types
  • also remove the dataset entities with empty field statistics from the MCE

🧪 Tested?

tested with include_view set to True and False, verified the results.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@alyiwang alyiwang enabled auto-merge (squash) October 22, 2024 19:29
Copy link

github-actions bot commented Oct 22, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13097 11684 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/postgresql/profile/extractor.py 74% 🟢
TOTAL 74% 🟢

updated for commit: 8637885 by action🐍

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.21%. Comparing base (a3c1d7c) to head (8637885).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/postgresql/profile/extractor.py 57.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
- Coverage   89.21%   89.21%   -0.01%     
==========================================
  Files         200      200              
  Lines       13091    13097       +6     
==========================================
+ Hits        11679    11684       +5     
- Misses       1412     1413       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add some tests to prevent similar regression in the future?

@alyiwang
Copy link
Contributor Author

Can we also add some tests to prevent similar regression in the future?

added

@alyiwang alyiwang merged commit 4dcad79 into main Oct 22, 2024
4 checks passed
@alyiwang alyiwang deleted the yi.wang/sc-29514/redshift-profiler-missing-tables branch October 22, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants