Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-29500] Exclude should work if it ends in /* #1015

Merged

Conversation

usefulalgorithm
Copy link
Contributor

🤔 Why?

If the excluded path ends in /*, all files within the directory should be excluded.

🤓 What?

  • If the excluded path ends in /*, all files within the directory should be excluded.
  • The other issue where the exclusion rule contains wildcard in template label part name will be addressed in a separate PR. It requires much more work to do properly.

🧪 Tested?

Added unit test.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13092 11679 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/s3/path_spec.py 94% 🟢
TOTAL 94% 🟢

updated for commit: 44defc8 by action🐍

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (d6bfc9d) to head (44defc8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1015   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files         200      200           
  Lines       13090    13092    +2     
=======================================
+ Hits        11677    11679    +2     
  Misses       1413     1413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@usefulalgorithm usefulalgorithm merged commit a78145a into main Oct 22, 2024
6 checks passed
@usefulalgorithm usefulalgorithm deleted the tsung-julii/sc-29500/exclude-all-files-in-excluded-path branch October 22, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants