Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake profiler is not normalizing the [sc-29479] #1014

Merged

Conversation

alyiwang
Copy link
Contributor

🤔 Why?

We have normalized the dataset column field path in table crawlers, but the profile crawlers missed this normalization and thus caused some mismatch.

🤓 What?

  • normalize the profiled column field path

🧪 Tested?

unit test
tested against snowflake instance

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

@alyiwang alyiwang enabled auto-merge (squash) October 21, 2024 19:14
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13049 11650 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/bigquery/profile/extractor.py 61% 🟢
metaphor/common/fieldpath.py 94% 🟢
metaphor/postgresql/profile/extractor.py 73% 🟢
metaphor/snowflake/profile/extractor.py 89% 🟢
metaphor/unity_catalog/profile/extractor.py 93% 🟢
TOTAL 82% 🟢

updated for commit: 0344fe2 by action🐍

@alyiwang alyiwang merged commit ba90653 into main Oct 21, 2024
4 checks passed
@alyiwang alyiwang deleted the yi.wang/sc-29479/snowflake-profiler-is-not-normalizing-the branch October 21, 2024 19:21
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.27%. Comparing base (c9f1c92) to head (0344fe2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1014   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files         200      200           
  Lines       13044    13049    +5     
=======================================
+ Hits        11645    11650    +5     
  Misses       1399     1399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants