Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve query log extraction for Athena connector #1011

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

elic-eon
Copy link
Contributor

@elic-eon elic-eon commented Oct 17, 2024

🤔 Why?

To redact literal in query logs

🤓 What?

  • Add query_log config
  • Use process_and_init_query_log to redact literal
  • Do not output query log out of (-lookback_days, now) time range.

🧪 Tested?

Updated unit tests and verified against dev.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link

github-actions bot commented Oct 17, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
13036 11638 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/athena/config.py 100% 🟢
metaphor/athena/extractor.py 93% 🟢
TOTAL 97% 🟢

updated for commit: 4a602d1 by action🐍

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.27%. Comparing base (64b95e3) to head (4a602d1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
metaphor/athena/extractor.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   89.26%   89.27%           
=======================================
  Files         200      200           
  Lines       13024    13036   +12     
=======================================
+ Hits        11626    11638   +12     
  Misses       1398     1398           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

metaphor/athena/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@usefulalgorithm usefulalgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go go go!

@elic-eon elic-eon merged commit 304b5d7 into main Oct 17, 2024
6 checks passed
@elic-eon elic-eon deleted the scotthuang/sc-29299/improve-athena-crawler branch October 17, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants