-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve query log extraction for Athena connector #1011
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
=======================================
Coverage 89.26% 89.27%
=======================================
Files 200 200
Lines 13024 13036 +12
=======================================
+ Hits 11626 11638 +12
Misses 1398 1398 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
Co-authored-by: Tsung-Ju Lii <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go go go!
🤔 Why?
To redact literal in query logs
🤓 What?
query_log
configprocess_and_init_query_log
to redact literal🧪 Tested?
Updated unit tests and verified against dev.
☑️ Checks
pyproject.toml
.