[sc-29393] MongoDB crawler ignore system collections #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars-lan
reviewed
Oct 17, 2024
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
=======================================
Coverage 89.25% 89.26%
=======================================
Files 200 200
Lines 13012 13024 +12
=======================================
+ Hits 11614 11626 +12
Misses 1398 1398 ☔ View full report in Codecov by Sentry. |
elic-eon
approved these changes
Oct 17, 2024
usefulalgorithm
deleted the
tsung-julii/sc-29393/mongodb-crawler-should-ignore-system-collections
branch
mars-lan
reviewed
Oct 17, 2024
| @@ -15,7 +15,7 @@ infer_schema_sample_size: <int> # Number of documents to sample in a collection | |||
| excluded_databases: # Databases to ignore. By default the databases "admin", "config", "local", "system" are excluded. | |||
There was a problem hiding this comment.
@usefulalgorithm Should alwsys exculde these as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
We are not supposed to crawl the system collections in MongoDB.
🤓 What?
🧪 Tested?
N/A.
☑️ Checks
pyproject.toml.