-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Postgres log extraction with log_duration disabled #1004
Merged
elic-eon
merged 5 commits into
main
from
scotthuang/sc-29242/support-postgres-log-without-duration
Oct 9, 2024
Merged
Support Postgres log extraction with log_duration disabled #1004
elic-eon
merged 5 commits into
main
from
scotthuang/sc-29242/support-postgres-log-without-duration
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
==========================================
- Coverage 89.50% 89.49% -0.01%
==========================================
Files 200 200
Lines 13061 13066 +5
==========================================
+ Hits 11690 11694 +4
- Misses 1371 1372 +1 ☔ View full report in Codecov by Sentry. |
elic-eon
force-pushed
the
scotthuang/sc-29242/support-postgres-log-without-duration
branch
from
October 9, 2024 09:03
6535fb1
to
4be973c
Compare
mars-lan
approved these changes
Oct 9, 2024
elic-eon
deleted the
scotthuang/sc-29242/support-postgres-log-without-duration
branch
October 9, 2024 16:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Why?
Since
log_duration
does not always default totrue
, we should be able to extract query history without duration.🤓 What?
log_duration_enabled
flag to default tofalse
to extract log without durationfilter_pattern
to speed up query log extractionexecute
statement and add testcase🧪 Tested?
Update unit tests, verified against dev postgres instance.
☑️ Checks
pyproject.toml
.