Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent bandit failures #1002

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Fix intermittent bandit failures #1002

merged 2 commits into from
Oct 7, 2024

Conversation

rishimo
Copy link
Contributor

@rishimo rishimo commented Oct 7, 2024

🤔 Why?

bandit intermittently catches some missing timeouts, causing CI to fail. This makes me sad.

🤓 What?

adds an appropriate timeout to the offending httpx calls

🧪 Tested?

CI suite run locally and passes.

☑️ Checks

  • My PR contains actual code changes, and I have updated the version number in pyproject.toml.

Copy link
Contributor

@elic-eon elic-eon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it

@rishimo rishimo enabled auto-merge (squash) October 7, 2024 16:18
Copy link

github-actions bot commented Oct 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
12992 11620 89% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
metaphor/dbt/cloud/extractor.py 89% 🟢
TOTAL 89% 🟢

updated for commit: 7f621b8 by action🐍

@rishimo rishimo merged commit 704a085 into main Oct 7, 2024
4 checks passed
@rishimo rishimo deleted the dbt-bandit-fix branch October 7, 2024 16:24
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (a865b5f) to head (7f621b8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1002   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files         199      199           
  Lines       12992    12992           
=======================================
  Hits        11620    11620           
  Misses       1372     1372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants