[sc-29858] Only update dbt_model.compiled_sql when `node.compile_co…

…mpleted_at` is defined (#1043) * [sc-29858] Only update `dbt_model.compiled_sql` when `node.compile_completed_at` is defined * mark generated stuff * mark schema as generated * fix test
MetaphorData · Nov 14, 2024 · db596ce · db596ce
1 parent 2f39bdd
commit db596ce
Show file tree

Hide file tree

Showing 14 changed files with 291 additions and 5 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1,2 @@
+/metaphor/dbt/cloud/discovery_api/generated/** linguist-generated
+/metaphor/dbt/cloud/discovery_api/schema.graphql linguist-generated
diff --git a/metaphor/dbt/cloud/discovery_api/generated/client.py b/metaphor/dbt/cloud/discovery_api/generated/client.py
diff --git a/metaphor/dbt/cloud/discovery_api/generated/enums.py b/metaphor/dbt/cloud/discovery_api/generated/enums.py
diff --git a/metaphor/dbt/cloud/discovery_api/generated/get_job_run_models.py b/metaphor/dbt/cloud/discovery_api/generated/get_job_run_models.py
diff --git a/metaphor/dbt/cloud/discovery_api/generated/get_job_run_snapshots.py b/metaphor/dbt/cloud/discovery_api/generated/get_job_run_snapshots.py
diff --git a/metaphor/dbt/cloud/discovery_api/queries.graphql b/metaphor/dbt/cloud/discovery_api/queries.graphql
@@ -10,6 +10,7 @@ query GetJobRunModels($jobId: BigInt!, $runId: BigInt!) {
         tags
         type
       }
+      compileCompletedAt
       compiledCode
       compiledSql
       database
@@ -47,6 +48,7 @@ query GetJobRunSnapshots($jobId: BigInt!, $runId: BigInt!) {
         type
       }
       comment
+      compileCompletedAt
       compiledCode
       compiledSql
       database

diff --git a/metaphor/dbt/cloud/discovery_api/schema.graphql b/metaphor/dbt/cloud/discovery_api/schema.graphql
diff --git a/metaphor/dbt/cloud/parser/dbt_node_parser.py b/metaphor/dbt/cloud/parser/dbt_node_parser.py
@@ -274,7 +274,9 @@ def parse(
 
         # raw_sql & complied_sql got renamed to raw_code & complied_code in V7
         dbt_model.raw_sql = node.raw_code or node.raw_sql
-        dbt_model.compiled_sql = node.compiled_code or node.compiled_sql
+        # Only update compiled sql if compilation actually completed
+        if node.compile_completed_at is not None:
+            dbt_model.compiled_sql = node.compiled_code or node.compiled_sql
 
         self._parse_model_materialization(node, dbt_model)
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "metaphor-connectors"
-version = "0.14.156"
+version = "0.14.157"
 license = "Apache-2.0"
 description = "A collection of Python-based 'connectors' that extract metadata from various sources to ingest into the Metaphor app."
 authors = ["Metaphor <[email protected]>"]
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		/metaphor/dbt/cloud/discovery_api/generated/** linguist-generated
		/metaphor/dbt/cloud/discovery_api/schema.graphql linguist-generated