Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run the "Main" workflow on release branches #29704

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Jan 14, 2025

Description

Open in GitHub Codespaces

This PR adds the glob expression "Version-v*" to run the "Main" workflow on release branches, thus allowing us to upload builds to Runway. It also modifies the Runway action to only run on release branches.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3619

Manual testing steps

  1. Runway build artifacts should be uploaded on release branches.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Jan 14, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

dbrans
dbrans previously approved these changes Jan 14, 2025
DDDDDanica
DDDDDanica previously approved these changes Jan 14, 2025
@itsyoboieltr itsyoboieltr dismissed stale reviews from DDDDDanica and dbrans via 619cf3d January 14, 2025 17:51
dbrans
dbrans previously approved these changes Jan 14, 2025
Copy link
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DDDDDanica
DDDDDanica previously approved these changes Jan 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [619cf3d]
Page Load Metrics (1925 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28223541523698335
domContentLoaded16292403189720699
load164024721925219105
domInteractive3011049199
backgroundConnect4118292914
firstReactRender1788442613
getState68617199
initialActions01000
loadScripts11411800139318187
setupStore764202110
uiStartup188428732215277133
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 259 Bytes (0.00%)
  • ui: 5.55 KiB (0.07%)
  • common: -625 Bytes (-0.01%)

@itsyoboieltr itsyoboieltr dismissed stale reviews from DDDDDanica and dbrans via 688aad5 January 14, 2025 18:58
@metamaskbot
Copy link
Collaborator

Builds ready [688aad5]
Page Load Metrics (1672 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1523183916798440
domContentLoaded1510179416457536
load1524182716727637
domInteractive24196464321
backgroundConnect96626167
firstReactRender16101433115
getState54312115
initialActions01000
loadScripts1109137312386632
setupStore585302914
uiStartup171525771999227109
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -137 Bytes (-0.00%)
  • ui: 5.55 KiB (0.07%)
  • common: -625 Bytes (-0.01%)

@itsyoboieltr itsyoboieltr added this pull request to the merge queue Jan 14, 2025
@itsyoboieltr itsyoboieltr removed this pull request from the merge queue due to a manual request Jan 14, 2025
@itsyoboieltr itsyoboieltr added this pull request to the merge queue Jan 14, 2025
@itsyoboieltr itsyoboieltr removed this pull request from the merge queue due to a manual request Jan 14, 2025
@itsyoboieltr itsyoboieltr added this pull request to the merge queue Jan 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [72e713a]
Page Load Metrics (1575 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1441169015716833
domContentLoaded1425164415506330
load1442169615757134
domInteractive21102402412
backgroundConnect76822178
firstReactRender1568292010
getState45713157
initialActions01000
loadScripts1042124911445828
setupStore571192311
uiStartup16662279182615675
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit 220435a Jan 14, 2025
80 checks passed
@itsyoboieltr itsyoboieltr deleted the fix/runway-release-filter branch January 14, 2025 21:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants