Skip to content

Commit

Permalink
feat: run the "Main" workflow on release branches (#29704)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29704?quickstart=1)

This PR adds the glob expression "Version-v*" to run the "Main" workflow
on release branches, thus allowing us to upload builds to Runway. It
also modifies the Runway action to only run on release branches.

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3619

## **Manual testing steps**

1. Runway build artifacts should be uploaded on release branches.

## **Screenshots/Recordings**

Not applicable

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
itsyoboieltr authored Jan 14, 2025
1 parent 810b165 commit 220435a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
branches:
- main
- master
- Version-v*
pull_request:
types:
- opened
Expand Down Expand Up @@ -67,6 +68,9 @@ jobs:

runway:
name: Runway
# For a `pull_request` event, the branch is `github.head_ref``.
# For a `push` event, the branch is `github.ref_name`.
if: ${{ startsWith(github.head_ref || github.ref_name, 'Version-v') }}
needs:
- wait-for-circleci-workflow-status
uses: ./.github/workflows/runway.yml
Expand Down Expand Up @@ -96,7 +100,6 @@ jobs:
- validate-lavamoat-policy-webapp
- run-tests
- wait-for-circleci-workflow-status
- runway
outputs:
PASSED: ${{ steps.set-output.outputs.PASSED }}
steps:
Expand Down

0 comments on commit 220435a

Please sign in to comment.