Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Temp testing branch dependency #29391

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hjetpoluru
Copy link
Contributor

@hjetpoluru hjetpoluru commented Dec 20, 2024

Description

Testing this PR #29370

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Gudahtt and others added 2 commits December 20, 2024 00:34
Migrate dependency/lockfile linting steps from CircleCI to GitHub
actions.

Relates to #28572

These changes were extracted from #29256
@hjetpoluru hjetpoluru added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 20, 2024
@hjetpoluru hjetpoluru self-assigned this Dec 20, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 20, 2024
@hjetpoluru hjetpoluru mentioned this pull request Dec 20, 2024
7 tasks
github-merge-queue bot pushed a commit that referenced this pull request Dec 20, 2024
## **Description**

Migrate dependency/lockfile linting steps from CircleCI to GitHub
actions.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29370?quickstart=1)

## **Related issues**

Relates to #28572

These changes were extracted from #29256

## **Manual testing steps**

Review logs to ensure the same commands are run. Introduce errors on a
branch from here to ensure the problems are caught.
#29391

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants