Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Migrate dependency linting #29370

Merged
merged 1 commit into from
Dec 20, 2024
Merged

ci: Migrate dependency linting #29370

merged 1 commit into from
Dec 20, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 20, 2024

Description

Migrate dependency/lockfile linting steps from CircleCI to GitHub actions.

Open in GitHub Codespaces

Related issues

Relates to #28572

These changes were extracted from #29256

Manual testing steps

Review logs to ensure the same commands are run. Introduce errors on a branch from here to ensure the problems are caught.
#29391

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Migrate dependency/lockfile linting steps from CircleCI to GitHub
actions.

Relates to #28572

These changes were extracted from #29256
@Gudahtt Gudahtt marked this pull request as ready for review December 20, 2024 04:45
@Gudahtt Gudahtt requested a review from a team as a code owner December 20, 2024 04:45
@metamaskbot
Copy link
Collaborator

Builds ready [a0bbbeb]
Page Load Metrics (1621 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14462179162717685
domContentLoaded14262172159216479
load14352177162118086
domInteractive2376412010
backgroundConnect8201364421
firstReactRender16100422914
getState48513199
initialActions01000
loadScripts10291790119516479
setupStore66518209
uiStartup161427241943295142
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@desi desi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a comment just for myself or anyone else who is looking in the future.

executor: node-browsers-small
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: sudo corepack enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for myself: This step is now done in environment setup.

@Gudahtt Gudahtt added this pull request to the merge queue Dec 20, 2024
@Gudahtt Gudahtt removed this pull request from the merge queue due to a manual request Dec 20, 2024
@Gudahtt Gudahtt added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit a02799d Dec 20, 2024
88 checks passed
@Gudahtt Gudahtt deleted the migrate-depcheck branch December 20, 2024 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-extension-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants