-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Migrate dependency linting #29370
Conversation
Builds ready [a0bbbeb]
Page Load Metrics (1621 ± 86 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left a comment just for myself or anyone else who is looking in the future.
executor: node-browsers-small | ||
steps: | ||
- run: *shallow-git-clone-and-enable-vnc | ||
- run: sudo corepack enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for myself: This step is now done in environment setup.
Description
Migrate dependency/lockfile linting steps from CircleCI to GitHub actions.
Related issues
Relates to #28572
These changes were extracted from #29256
Manual testing steps
Review logs to ensure the same commands are run. Introduce errors on a branch from here to ensure the problems are caught.
#29391
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist