Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated message string in onboarding screen #29286

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix: updated message string in onboarding screen #29286

merged 2 commits into from
Dec 17, 2024

Conversation

NidhiKJha
Copy link
Member

This PR is to update the onboarding screen message with proper punctuation

Related issues

Fixes: #26763

Manual testing steps

  1. Go to onboarding
  2. Check the message has proper punctuation on this screen

Screenshots/Recordings

Before

Screenshot 2024-12-17 at 4 40 06 PM

After

Screenshot 2024-12-17 at 4 39 51 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica
Copy link
Contributor

LGTM ! Added a comment in original ticket for a NIT improvement, we can wait for content designer Corey's response on that one 🙏🏻

@metamaskbot
Copy link
Collaborator

Builds ready [6e7a975]
Page Load Metrics (1605 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22119701524331159
domContentLoaded13991940158113866
load14182022160515474
domInteractive24163393115
backgroundConnect982272412
firstReactRender1682382411
getState44710105
initialActions01000
loadScripts9891439116311153
setupStore65916178
uiStartup15812254182317484
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1 Bytes (0.00%)

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
I didn't realize we used the oxford comma but sure enough it's a ticket written by Sally and it's in our content guidelines! TIL

Screenshot 2024-12-18 at 7 48 10 AM

@NidhiKJha NidhiKJha enabled auto-merge December 17, 2024 22:10
@metamaskbot
Copy link
Collaborator

Builds ready [ebd5bb2]
Page Load Metrics (1670 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15012072168013263
domContentLoaded14892058164812761
load15022073167012861
domInteractive20100402211
backgroundConnect95325147
firstReactRender1689372713
getState471172110
initialActions01000
loadScripts10901642124111655
setupStore611711
uiStartup16982315188213866
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1 Bytes (0.00%)

@NidhiKJha NidhiKJha added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 80ec747 Dec 17, 2024
77 checks passed
@NidhiKJha NidhiKJha deleted the fix-26763 branch December 17, 2024 23:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Onboarding "Explore decentralized apps" screen missing oxford comma
4 participants