Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Onboarding "Explore decentralized apps" screen missing oxford comma #26763

Closed
sallykhomikh opened this issue Aug 29, 2024 · 3 comments · Fixed by #29286
Closed

[Bug]: Onboarding "Explore decentralized apps" screen missing oxford comma #26763

sallykhomikh opened this issue Aug 29, 2024 · 3 comments · Fixed by #29286
Assignees
@NidhiKJha @sallykhomikh
Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) needs-content Needs content / copy support. regression-prod-11.16.16 Regression bug that was found in production in release 11.16.16 release-12.11.0 Issue or pull request that will be included in release 12.11.0 Sev3-low Low severity; minimal to no impact upon users team-design-system All issues relating to design system in Extension type-bug

Comments

@sallykhomikh
Copy link

Describe the bug

Missing oxford comma in subtext.

Expected behavior

Should say "Store, send, and spend crypto currencies and assets."

Screenshots/Recordings

Screenshot 2024-08-29 at 11 38 00 AM

Steps to reproduce

Add comma

Error messages or log output

NA

Detection stage

In production (default)

Version

11.16.16

Build type

None

Browser

Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

NA

Severity

Not severe
@sallykhomikh sallykhomikh added type-bug needs-content Needs content / copy support. area-design Design bug (previously known as papercuts - ask Hilary for more detail) labels Aug 29, 2024
@sallykhomikh sallykhomikh self-assigned this Aug 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Aug 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Aug 29, 2024
@metamaskbot metamaskbot added the regression-prod-11.16.16 Regression bug that was found in production in release 11.16.16 label Aug 29, 2024
@Nick-Son Nick-Son added Sev3-low Low severity; minimal to no impact upon users team-design-system All issues relating to design system in Extension labels Aug 30, 2024
@desi desi added the type-bug label Oct 2, 2024
@NidhiKJha NidhiKJha self-assigned this Dec 17, 2024
@NidhiKJha NidhiKJha mentioned this issue Dec 17, 2024
Merged
7 tasks
@NidhiKJha
Copy link
Member

Fixed by #29286

@DDDDDanica
Copy link
Contributor

[Non-blocking]: @coreyjanssen @NidhiKJha just looking at the full sentence, we can also rename crypto currencies into cryptocurrencies, wdyt?

@coreyjanssen
Copy link
Contributor

100% agree!! Great catch @DDDDDanica!

github-merge-queue bot pushed a commit that referenced this issue Dec 17, 2024
@NidhiKJha
fix: updated message string in onboarding screen (#29286)
80ec747 
This PR is to update the onboarding screen message with proper
punctuation

## **Related issues**

Fixes: #26763 

## **Manual testing steps**

1. Go to onboarding
2. Check the message has proper punctuation on this screen

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
![Screenshot 2024-12-17 at 4 40
06 PM](https://github.com/user-attachments/assets/94bf0296-b412-460f-a136-034264d07140)


### **After**

![Screenshot 2024-12-17 at 4 39
51 PM](https://github.com/user-attachments/assets/bea72254-5479-4252-b2dc-03f0dac2316f)

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Dec 17, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Dec 17, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NidhiKJha NidhiKJha

@sallykhomikh sallykhomikh

Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) needs-content Needs content / copy support. regression-prod-11.16.16 Regression bug that was found in production in release 11.16.16 release-12.11.0 Issue or pull request that will be included in release 12.11.0 Sev3-low Low severity; minimal to no impact upon users team-design-system All issues relating to design system in Extension type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: updated message string in onboarding screen MetaMask/metamask-extension
8 participants
@desi @DDDDDanica @Nick-Son @metamaskbot @NidhiKJha @hilvmason @coreyjanssen @sallykhomikh