Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sentry e2e test for bridge tokens loading status #29285

Merged
merged 4 commits into from
Dec 17, 2024
+2 −4
Merged

fix: sentry e2e test for bridge tokens loading status #29285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b4097c
fix: sentry e2e test
micaelae Dec 17, 2024
62f1425
test: run firefox tests in PR
micaelae Dec 17, 2024
2f46607
test: include loading status in sentry
micaelae Dec 17, 2024
358315e
Revert "test: run firefox tests in PR"
micaelae Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/scripts/constants/sentry-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ export const SENTRY_BACKGROUND_STATE = {
},
destTokens: {},
destTopAssets: [],
destTokensLoadingStatus: false,
destTokensLoadingStatus: true,
srcTokens: {},
srcTopAssets: [],
srcTokensLoadingStatus: false,
srcTokensLoadingStatus: true,
quoteRequest: {
walletAddress: false,
srcTokenAddress: true,
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@
"srcTokens": {},
"srcTopAssets": {},
"destTokens": {},
"destTokensLoadingStatus": "undefined",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggests that these default to undefined. Is that intended?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, these are optional: https://github.com/MetaMask/metamask-extension/pull/28373/files#diff-5f37a2a6ea0903094f4dbc84f86b96733525a125a5c66770527bd7e32a5b832aR40

This seems OK then

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is! This is the state when the list is unfetched. These are going to be deprecated by the next release in favor of the multichain asset lists so this will be cleaned up soon

"srcTokensLoadingStatus": "undefined",
"destTopAssets": {},
"quoteRequest": {
"srcTokenAddress": "0x0000000000000000000000000000000000000000",
Expand Down
Loading