-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sentry e2e test for bridge tokens loading status #29285
Conversation
Builds ready [2f46607]
Page Load Metrics (1808 ± 149 ms)
Bundle size diffs
|
@@ -76,8 +76,6 @@ | |||
"srcTokens": {}, | |||
"srcTopAssets": {}, | |||
"destTokens": {}, | |||
"destTokensLoadingStatus": "undefined", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suggests that these default to undefined
. Is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, these are optional: https://github.com/MetaMask/metamask-extension/pull/28373/files#diff-5f37a2a6ea0903094f4dbc84f86b96733525a125a5c66770527bd7e32a5b832aR40
This seems OK then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is! This is the state when the list is unfetched. These are going to be deprecated by the next release in favor of the multichain asset lists so this will be cleaned up soon
Builds ready [358315e]
Page Load Metrics (1578 ± 39 ms)
Bundle size diffs
|
Description
Fixes sentry tests for bridge token loading status in Firefox
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist