Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sentry e2e test for bridge tokens loading status #29285

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Dec 17, 2024

Description

Fixes sentry tests for bridge token loading status in Firefox

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae marked this pull request as ready for review December 17, 2024 16:37
@micaelae micaelae changed the title fix: sentry e2e test fix: sentry e2e test for bridge tokens loading status Dec 17, 2024
@micaelae micaelae marked this pull request as draft December 17, 2024 16:42
@micaelae micaelae marked this pull request as ready for review December 17, 2024 17:43
@micaelae micaelae requested a review from a team December 17, 2024 17:45
@metamaskbot
Copy link
Collaborator

Builds ready [2f46607]
Page Load Metrics (1808 ± 149 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23729471734457219
domContentLoaded146528911776302145
load147429641808311149
domInteractive25102472211
backgroundConnect1070292110
firstReactRender1777332210
getState563212110
initialActions01000
loadScripts107020371313211101
setupStore667182010
uiStartup171432642052336161
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@@ -76,8 +76,6 @@
"srcTokens": {},
"srcTopAssets": {},
"destTokens": {},
"destTokensLoadingStatus": "undefined",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggests that these default to undefined. Is that intended?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is! This is the state when the list is unfetched. These are going to be deprecated by the next release in favor of the multichain asset lists so this will be cleaned up soon

@micaelae micaelae enabled auto-merge December 17, 2024 18:04
@metamaskbot
Copy link
Collaborator

Builds ready [358315e]
Page Load Metrics (1578 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1471175615838239
domContentLoaded1409171115538541
load1443172215788239
domInteractive2310133178
backgroundConnect105629178
firstReactRender1574272010
getState44811126
initialActions01000
loadScripts1034131611627938
setupStore66412157
uiStartup1657197017879144
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 241c9d8 Dec 17, 2024
80 checks passed
@micaelae micaelae deleted the bridge-loading-state-sentry-test branch December 17, 2024 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants