build(webpack): fix --zip
in Node.js 22 by cloning assets into Uint8Array
s before zipping
#29177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a copy of the Buffer via
Buffer.from(asset)
, as Zip will consume it, which breaks things if we are compiling for multiple browsers at once.Buffer.from
uses the internal pool, so it's superior tonew Uint8Array
if we don't need to pass it off to a worker thread.Additionally, in Node.js 22+ a Buffer marked as "Untransferable" (like ours) can't be passed to a worker, which
AsyncZipDeflate
uses. See: 101arrowz/fflate#227 (comment)This can probably be simplified to
zipFile.push(Buffer.from(asset), true);
if the above issue is resolved.This fix should hopefully unblock #28368