Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wiping txHistory on both source and dest chains #29000

Merged
merged 1 commit into from
Dec 9, 2024
+2 −6
Merged

fix: wiping txHistory on both source and dest chains #29000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions app/scripts/controllers/bridge-status/bridge-status-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ export default class BridgeStatusController extends StaticIntervalPollingControl
};

// Wipes the bridge status for the given address and chainId
// Will match either source or destination chainId to the selectedChainId
// Will match only source chainId to the selectedChainId
#wipeBridgeStatusByChainId = (address: string, selectedChainId: Hex) => {
const sourceTxMetaIdsToDelete = Object.keys(
this.state.bridgeStatusState.txHistory,
Expand All @@ -324,14 +324,10 @@ export default class BridgeStatusController extends StaticIntervalPollingControl
const hexSourceChainId = decimalToPrefixedHex(
bridgeHistoryItem.quote.srcChainId,
);
const hexDestChainId = decimalToPrefixedHex(
bridgeHistoryItem.quote.destChainId,
);

return (
bridgeHistoryItem.account === address &&
(hexSourceChainId === selectedChainId ||
hexDestChainId === selectedChainId)
hexSourceChainId === selectedChainId
);
});

Expand Down
Loading