Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wiping txHistory on both source and dest chains #29000

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 6, 2024

Description

Open in GitHub Codespaces

This PR fixes an issue for Bridge txs where both the source chain AND destination chain txHistory get wiped when the user clears their Activity tab data.

Related issues

Fixes:

Manual testing steps

  1. Add BRIDGE_USE_DEV_APIS=1 to .metamaskrc
  2. Do a bridge from chain 1 to chain 2
  3. Switch to chain 2
  4. Do a bridge from chain 2 to another chain
  5. Go into Settings > Advanced > Click Clear activity
  6. Observe that chain 2's tx are gone
  7. Switch to chain 1
  8. Observe that chain 1's bridge tx has the proper values

Screenshots/Recordings

Before

Screen.Recording.2024-12-06.at.2.07.55.PM.mov

After

Screen.Recording.2024-12-06.at.2.04.56.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review December 6, 2024 19:08
@metamaskbot
Copy link
Collaborator

Builds ready [b0e22ab]
Page Load Metrics (1842 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16382087184711254
domContentLoaded1630199918189948
load16382049184210651
domInteractive24583194
backgroundConnect990302110
firstReactRender159221168
getState792981324823
initialActions01000
loadScripts1229156114099244
setupStore67511157
uiStartup186128682145237114
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -59 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 51e67b4 Dec 9, 2024
104 checks passed
@micaelae micaelae deleted the mb1787-xchain-fix-bridge-status-clear-network branch December 9, 2024 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-bridge team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants