Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update signature controller #28988

Merged
merged 2 commits into from
Dec 6, 2024
Merged

chore: Update signature controller #28988

merged 2 commits into from
Dec 6, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 6, 2024

Description

Update signature controller to fix signature decoding issues.

  1. fix: Fixes in signature decoding functionality core#5028
  2. fix: signature decoding api should be called for typed sign V3 also core#5033

Related issues

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Dec 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network +1 1.01 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@jpuri
Copy link
Contributor Author

jpuri commented Dec 6, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@metamaskbot
Copy link
Collaborator

Builds ready [b6b31e3]
Page Load Metrics (2027 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24725181857537258
domContentLoaded17162424199716479
load17252431202716479
domInteractive277241126
backgroundConnect889282311
firstReactRender17562284
getState971801392010
initialActions01000
loadScripts13041849153013665
setupStore7401184
uiStartup20022849233719794
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 7.08 KiB (0.09%)

@jpuri jpuri added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 9e70c73 Dec 6, 2024
75 checks passed
@jpuri jpuri deleted the sig_ctrl_update branch December 6, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants