Skip to content

Commit

Permalink
chore: Update signature controller (#28988)
Browse files Browse the repository at this point in the history
## **Description**

Update signature controller to fix signature decoding issues.
1. MetaMask/core#5028
2. MetaMask/core#5033


## **Related issues**

* Related to: MetaMask/MetaMask-planning#3756
* Related to: MetaMask/MetaMask-planning#3757

## **Manual testing steps**
NA

## **Screenshots/Recordings**
NA

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
jpuri authored Dec 6, 2024
1 parent 8de03c0 commit 9e70c73
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@
"@metamask/safe-event-emitter": "^3.1.1",
"@metamask/scure-bip39": "^2.0.3",
"@metamask/selected-network-controller": "^19.0.0",
"@metamask/signature-controller": "^23.0.0",
"@metamask/signature-controller": "^23.1.0",
"@metamask/smart-transactions-controller": "^15.0.0",
"@metamask/snaps-controllers": "^9.15.0",
"@metamask/snaps-execution-environments": "^6.10.0",
Expand Down
22 changes: 11 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6087,23 +6087,23 @@ __metadata:
languageName: node
linkType: hard

"@metamask/signature-controller@npm:^23.0.0":
version: 23.0.0
resolution: "@metamask/signature-controller@npm:23.0.0"
"@metamask/signature-controller@npm:^23.1.0":
version: 23.1.0
resolution: "@metamask/signature-controller@npm:23.1.0"
dependencies:
"@metamask/base-controller": "npm:^7.0.2"
"@metamask/controller-utils": "npm:^11.4.3"
"@metamask/controller-utils": "npm:^11.4.4"
"@metamask/eth-sig-util": "npm:^8.0.0"
"@metamask/utils": "npm:^10.0.0"
jsonschema: "npm:^1.2.4"
jsonschema: "npm:^1.4.1"
lodash: "npm:^4.17.21"
uuid: "npm:^8.3.2"
peerDependencies:
"@metamask/approval-controller": ^7.0.0
"@metamask/keyring-controller": ^19.0.0
"@metamask/logging-controller": ^6.0.0
"@metamask/network-controller": ^22.0.0
checksum: 10/5e2fda2d89dd3433f00028da0fa7743a6934b72f33fc0e4803dafa98702b9bdd9d093a326060d5480e6eb065c6b4cc1dc3e39382c00702f28b5a6061e8f105bf
checksum: 10/2f97e6412bc3a3a13aa2106dfd679500680881918a6e3e2621d4e225e6380df7a01218f7ce26747575b09c85d8ac8be2f5029240339b28fc6d849fad480c5b72
languageName: node
linkType: hard

Expand Down Expand Up @@ -24639,10 +24639,10 @@ __metadata:
languageName: node
linkType: hard

"jsonschema@npm:^1.2.4":
version: 1.2.4
resolution: "jsonschema@npm:1.2.4"
checksum: 10/7b959737416a5716f2df3142e30c8685bc5449974d56d1cd5acbbd61c0f71041af38fa315327c8577fcdbe30907fd9b633c4d3484baf2cc8563609afac5b4e14
"jsonschema@npm:^1.2.4, jsonschema@npm:^1.4.1":
version: 1.4.1
resolution: "jsonschema@npm:1.4.1"
checksum: 10/d7a188da7a3100a2caa362b80e98666d46607b7a7153aac405b8e758132961911c6df02d444d4700691330874e21a62639f550e856b21ddd28423690751ca9c6
languageName: node
linkType: hard

Expand Down Expand Up @@ -26454,7 +26454,7 @@ __metadata:
"@metamask/safe-event-emitter": "npm:^3.1.1"
"@metamask/scure-bip39": "npm:^2.0.3"
"@metamask/selected-network-controller": "npm:^19.0.0"
"@metamask/signature-controller": "npm:^23.0.0"
"@metamask/signature-controller": "npm:^23.1.0"
"@metamask/smart-transactions-controller": "npm:^15.0.0"
"@metamask/snaps-controllers": "npm:^9.15.0"
"@metamask/snaps-execution-environments": "npm:^6.10.0"
Expand Down

0 comments on commit 9e70c73

Please sign in to comment.