Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update a mock for tests #28934

Merged
merged 2 commits into from
Dec 4, 2024
Merged

chore: Update a mock for tests #28934

merged 2 commits into from
Dec 4, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Dec 4, 2024

Description

The mock has been updated to be less specific, so that the mocked network response is used in more situations. This is meant to address a frequently failing flaky test (example: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/113905/workflows/1140e350-cf29-45ff-916e-6fa0f3befc67/jobs/4268755/parallel-runs/16)

Open in GitHub Codespaces

Related issues

No issue yet

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 requested a review from a team as a code owner December 4, 2024 17:18
Copy link
Contributor

github-actions bot commented Dec 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-transactions Transactions team label Dec 4, 2024
@dan437 dan437 changed the title chore: Skip a test until it's updated chore: Update a mock for tests Dec 4, 2024
@Gudahtt
Copy link
Member

Gudahtt commented Dec 4, 2024

Just updated the PR description with more details. Please try to fill out the template in the future, even if the content is minimal. Something is better than nothing.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dan437 dan437 enabled auto-merge December 4, 2024 18:11
@Gudahtt Gudahtt disabled auto-merge December 4, 2024 18:13
@Gudahtt Gudahtt merged commit 95301f4 into main Dec 4, 2024
79 of 81 checks passed
@Gudahtt Gudahtt deleted the stx-test branch December 4, 2024 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [bf16260]
Page Load Metrics (1851 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22621511791392188
domContentLoaded15882129182614871
load16092158185115976
domInteractive25653395
backgroundConnect783232110
firstReactRender15311942
getState1103121544019
initialActions00000
loadScripts11511695138514268
setupStore7271263
uiStartup188127912162239115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants