Skip to content

Commit

Permalink
chore: Update a mock for tests (#28934)
Browse files Browse the repository at this point in the history
## **Description**

The mock has been updated to be less specific, so that the mocked
network response is used in more situations. This is meant to address a
frequently failing flaky test (example:
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/113905/workflows/1140e350-cf29-45ff-916e-6fa0f3befc67/jobs/4268755/parallel-runs/16)

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28934?quickstart=1)

## **Related issues**

No issue yet

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
dan437 authored Dec 4, 2024
1 parent fc8e51e commit 95301f4
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const GET_FEES_REQUEST_INCLUDES = {
from: '0x5cfe73b6021e818b776b421b1c4db2474086a7e1',
to: '0x881D40237659C251811CEC9c364ef91dC08D300C',
value: '0x1bc16d674ec80000',
gas: '0xf4240',
nonce: '0x0',
},
],
Expand Down

0 comments on commit 95301f4

Please sign in to comment.