-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rename develop
to main
#28821
Merged
+130
−130
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,11 +45,11 @@ rc_branch_only: &rc_branch_only | |
only: | ||
- /^Version-v(\d+)[.](\d+)[.](\d+)/ | ||
|
||
develop_master_rc_only: &develop_master_rc_only | ||
main_master_rc_only: &main_master_rc_only | ||
filters: | ||
branches: | ||
only: | ||
- develop | ||
- main | ||
- master | ||
- /^Version-v(\d+)[.](\d+)[.](\d+)/ | ||
|
||
|
@@ -172,7 +172,7 @@ workflows: | |
requires: | ||
- prep-deps | ||
- prep-build-test-flask-mv2: | ||
<<: *develop_master_rc_only | ||
<<: *main_master_rc_only | ||
requires: | ||
- prep-deps | ||
- prep-build-test-mmi: | ||
|
@@ -200,7 +200,7 @@ workflows: | |
requires: | ||
- prep-deps | ||
- test-e2e-chrome-webpack: | ||
<<: *develop_master_rc_only | ||
<<: *main_master_rc_only | ||
requires: | ||
- prep-build-test-webpack | ||
- get-changed-files-with-git-diff | ||
|
@@ -209,7 +209,7 @@ workflows: | |
- prep-build-test | ||
- get-changed-files-with-git-diff | ||
- test-e2e-firefox: | ||
<<: *develop_master_rc_only | ||
<<: *main_master_rc_only | ||
requires: | ||
- prep-build-test-mv2 | ||
- get-changed-files-with-git-diff | ||
|
@@ -229,7 +229,7 @@ workflows: | |
- prep-build-test-flask | ||
- get-changed-files-with-git-diff | ||
- test-e2e-firefox-flask: | ||
<<: *develop_master_rc_only | ||
<<: *main_master_rc_only | ||
requires: | ||
- prep-build-test-flask-mv2 | ||
- test-e2e-chrome-mmi: | ||
|
@@ -250,7 +250,7 @@ workflows: | |
filters: | ||
branches: | ||
only: | ||
- develop | ||
- main | ||
- /^Version-v(\d+)[.](\d+)[.](\d+)/ | ||
requires: | ||
- prep-build | ||
|
@@ -349,13 +349,13 @@ workflows: | |
- job-publish-storybook: | ||
filters: | ||
branches: | ||
only: develop | ||
only: main | ||
requires: | ||
- prep-build-storybook | ||
- job-publish-ts-migration-dashboard: | ||
filters: | ||
branches: | ||
only: develop | ||
only: main | ||
requires: | ||
- prep-build-ts-migration-dashboard | ||
|
||
|
@@ -367,7 +367,7 @@ workflows: | |
- rerun-workflows-from-failed: | ||
filters: | ||
branches: | ||
only: develop | ||
only: main | ||
requires: | ||
- prep-deps | ||
|
||
|
@@ -477,7 +477,7 @@ jobs: | |
|
||
# This job is used for the e2e quality gate. | ||
# It must be run before any job which uses the run-all.js script. | ||
# The job is skipped in develop, master or RC branches. | ||
# The job is skipped in main, master or RC branches. | ||
get-changed-files-with-git-diff: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
executor: node-browsers-small | ||
steps: | ||
|
@@ -1335,7 +1335,7 @@ jobs: | |
template: basic_fail_1 | ||
channel: C01LUJL3T98 | ||
- slack/notify: | ||
branch_pattern: develop | ||
branch_pattern: main | ||
event: fail | ||
mentions: <@antonio.regadas>, @ramon.acitores134 | ||
template: basic_fail_1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -132,7 +132,7 @@ async function main(): Promise<void> { | |
|
||
} else { | ||
const errorMessage = | ||
"Issue body does not match any of expected templates ('general-issue.yml' or 'bug-report.yml').\n\nMake sure issue's body includes all section titles.\n\nSections titles are listed here: https://github.com/MetaMask/metamask-extension/blob/develop/.github/scripts/shared/template.ts#L14-L37"; | ||
"Issue body does not match any of expected templates ('general-issue.yml' or 'bug-report.yml').\n\nMake sure issue's body includes all section titles.\n\nSections titles are listed here: https://github.com/MetaMask/metamask-extension/blob/main/.github/scripts/shared/template.ts#L14-L37"; | ||
console.log(errorMessage); | ||
|
||
// Add label to indicate issue doesn't match any template | ||
|
@@ -152,7 +152,7 @@ async function main(): Promise<void> { | |
); | ||
} else { | ||
const errorMessage = | ||
`PR body does not match template ('pull-request-template.md').\n\nMake sure PR's body includes all section titles.\n\nSections titles are listed here: https://github.com/MetaMask/metamask-extension/blob/develop/.github/scripts/shared/template.ts#L40-L47`; | ||
`PR body does not match template ('pull-request-template.md').\n\nMake sure PR's body includes all section titles.\n\nSections titles are listed here: https://github.com/MetaMask/metamask-extension/blob/main/.github/scripts/shared/template.ts#L40-L47`; | ||
console.log(errorMessage); | ||
|
||
// Add label to indicate PR body doesn't match template | ||
|
@@ -334,7 +334,7 @@ function craftRegressionLabel(regressionStage: RegressionStage | undefined, rele | |
switch (regressionStage) { | ||
case RegressionStage.Development: | ||
return { | ||
name: `regression-develop`, | ||
name: `regression-main`, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This label will need to be renamed |
||
color: '5319E7', // violet | ||
description: `Regression bug that was found on development branch, but not yet present in production`, | ||
}; | ||
|
@@ -364,7 +364,7 @@ function craftRegressionLabel(regressionStage: RegressionStage | undefined, rele | |
return { | ||
name: `regression-*`, | ||
color: 'EDEDED', // grey | ||
description: `TODO: Unknown regression stage. Please replace with correct regression label: 'regression-develop', 'regression-RC-x.y.z', or 'regression-prod-x.y.z' label, where 'x.y.z' is the number of the release where bug was found.`, | ||
description: `TODO: Unknown regression stage. Please replace with correct regression label: 'regression-main', 'regression-RC-x.y.z', or 'regression-prod-x.y.z' label, where 'x.y.z' is the number of the release where bug was found.`, | ||
}; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ on: | |
push: | ||
branches: | ||
- 'codespaces**' | ||
- 'develop' | ||
- 'main' | ||
paths: | ||
- '**/yarn.lock' | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ permissions: | |
on: | ||
push: | ||
branches: | ||
- develop | ||
- main | ||
schedule: | ||
- cron: "0 */12 * * *" | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ name: Main | |
on: | ||
push: | ||
branches: | ||
- develop | ||
- main | ||
- master | ||
pull_request: | ||
types: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this should run on the
master
branch as well, so we could reuse themain_master_rc_only
alias here. We can do this in a later PR though.