chore: Rename `develop` to `main` #28821

Gudahtt · 2024-11-29T17:50:05Z

Description

Rename references to the main branch. It will be called main rather than develop.

Related issues

Relates to https://github.com/MetaMask/MetaMask-planning/issues/3677/

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Gudahtt · 2024-11-29T17:53:32Z

.circleci/config.yml

@@ -477,7 +477,7 @@ jobs:

  # This job is used for the e2e quality gate.
  # It must be run before any job which uses the run-all.js script.
-  # The job is skipped in develop, master or RC branches.
+  # The job is skipped in main, master or RC branches.
  get-changed-files-with-git-diff:


The git-diff-develop.ts script should be renamed as well, but we can do that in a later PR

Gudahtt · 2024-11-29T17:53:49Z

.github/scripts/check-template-and-add-labels.ts

@@ -334,7 +334,7 @@ function craftRegressionLabel(regressionStage: RegressionStage | undefined, rele
  switch (regressionStage) {
    case RegressionStage.Development:
      return {
-        name: `regression-develop`,
+        name: `regression-main`,


This label will need to be renamed

Gudahtt · 2024-11-29T17:59:52Z

.circleci/config.yml

@@ -250,7 +250,7 @@ workflows:
          filters:
            branches:
              only:
-                - develop
+                - main


Seems like this should run on the master branch as well, so we could reuse the main_master_rc_only alias here. We can do this in a later PR though.

metamaskbot · 2024-11-29T18:22:59Z

Builds ready [205c755]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1859 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1657	2119	1866	113	54
		domContentLoaded	1646	2105	1838	114	55
		load	1654	2110	1859	111	54
		domInteractive	24	179	41	34	16
		backgroundConnect	8	69	23	18	9
		firstReactRender	15	100	24	18	9
		getState	49	177	92	27	13
		initialActions	0	1	0	0	0
		loadScripts	1228	1640	1394	106	51
		setupStore	7	80	17	19	9
		uiStartup	1863	2841	2125	211	101

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -3 Bytes (-0.00%)

github-actions · 2024-11-29T18:52:32Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

danjm

LGTM

metamaskbot · 2024-11-29T19:23:49Z

Builds ready [5a20bac]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1895 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1616	2272	1898	168	81
		domContentLoaded	1607	2204	1860	162	78
		load	1623	2276	1895	163	78
		domInteractive	24	185	44	35	17
		backgroundConnect	10	74	32	19	9
		firstReactRender	16	95	32	22	11
		getState	49	133	97	22	10
		initialActions	0	0	0	0	0
		loadScripts	1206	1744	1428	141	68
		setupStore	7	73	12	14	7
		uiStartup	1836	2688	2202	209	100

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -3 Bytes (-0.00%)

Rename references to the main branch. It will be called `main` rather than `develop`. Relates to MetaMask/MetaMask-planning#3677

metamaskbot · 2024-12-02T13:55:07Z

Builds ready [259f0b7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1687 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1510	1844	1689	91	44
		domContentLoaded	1504	1808	1657	83	40
		load	1511	1845	1687	86	41
		domInteractive	23	117	35	23	11
		backgroundConnect	8	69	32	20	10
		firstReactRender	14	85	26	20	10
		getState	47	189	79	33	16
		initialActions	0	1	0	0	0
		loadScripts	1069	1380	1249	77	37
		setupStore	6	48	9	9	4
		uiStartup	1734	2267	1920	113	54

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -3 Bytes (-0.00%)

Gudahtt added the team-extension-platform label Nov 29, 2024

metamaskbot added the team-wallet-framework label Nov 29, 2024

Gudahtt commented Nov 29, 2024

View reviewed changes

Gudahtt marked this pull request as ready for review November 29, 2024 18:28

Gudahtt requested review from a team, HowardBraham and kumavis as code owners November 29, 2024 18:28

danjm approved these changes Nov 29, 2024

View reviewed changes

pedronfigueiredo approved these changes Nov 29, 2024

View reviewed changes

HowardBraham approved these changes Nov 30, 2024

View reviewed changes

Gudahtt and others added 3 commits December 2, 2024 09:53

chore: Rename develop to main

67e5e4e

Rename references to the main branch. It will be called `main` rather than `develop`. Relates to MetaMask/MetaMask-planning#3677

Additional renaming

b0a66c6

One more renaming

259f0b7

Gudahtt force-pushed the rename-main-branch branch from 5a20bac to 259f0b7 Compare December 2, 2024 13:23

GuillaumeRx approved these changes Dec 2, 2024

View reviewed changes

Gudahtt added this pull request to the merge queue Dec 2, 2024

Gudahtt removed this pull request from the merge queue due to a manual request Dec 2, 2024

Gudahtt merged commit b6bf219 into main Dec 2, 2024
70 checks passed

Gudahtt deleted the rename-main-branch branch December 2, 2024 14:00

github-actions bot locked and limited conversation to collaborators Dec 2, 2024

metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Rename `develop` to `main` #28821

chore: Rename `develop` to `main` #28821

Gudahtt commented Nov 29, 2024 •

edited by github-actions bot

Loading

Gudahtt Nov 29, 2024

Gudahtt Nov 29, 2024

Gudahtt Nov 29, 2024

metamaskbot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

danjm left a comment

metamaskbot commented Nov 29, 2024

metamaskbot commented Dec 2, 2024

chore: Rename develop to main #28821

chore: Rename develop to main #28821

Conversation

Gudahtt commented Nov 29, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Gudahtt Nov 29, 2024

Choose a reason for hiding this comment

Gudahtt Nov 29, 2024

Choose a reason for hiding this comment

Gudahtt Nov 29, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

danjm left a comment

Choose a reason for hiding this comment

metamaskbot commented Nov 29, 2024

metamaskbot commented Dec 2, 2024

chore: Rename `develop` to `main` #28821

chore: Rename `develop` to `main` #28821

Gudahtt commented Nov 29, 2024 •

edited by github-actions bot

Loading