Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(TXL-308): initial e2e for stx using swaps #27215

Merged
merged 17 commits into from
Oct 15, 2024
Merged

test(TXL-308): initial e2e for stx using swaps #27215

merged 17 commits into from
Oct 15, 2024

Conversation

dbrans
Copy link
Contributor

@dbrans dbrans commented Sep 17, 2024 •
edited
Loading

Description

  • Initial e2e test for stx

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dbrans dbrans requested review from a team as code owners September 17, 2024 13:00
@dbrans dbrans marked this pull request as draft September 17, 2024 13:00
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-transactions Transactions team label Sep 17, 2024
@dbrans dbrans changed the title test(stx): initial e2e for stx using swaps test(stx): initial e2e for stx using swaps – TXL-308 Sep 17, 2024
@dbrans dbrans changed the title test(stx): initial e2e for stx using swaps – TXL-308 test(TXL-308): initial e2e for stx using swaps Sep 17, 2024
@dbrans dbrans marked this pull request as ready for review September 17, 2024 13:18
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [fff9e5d]
Page Load Metrics (1917 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24821761657598287
domContentLoaded16922167189113163
load17032195191713967
domInteractive14144443115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 177 Bytes (0.00%)
  • ui: 111 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ad69471]
Page Load Metrics (1844 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29925181758395190
domContentLoaded155824041804208100
load156825311844229110
domInteractive1399362110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 177 Bytes (0.00%)
  • ui: 111 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [b0c6e80]
Page Load Metrics (1839 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32823261686461221
domContentLoaded147923131818209101
load149123881839217104
domInteractive13192484019
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 177 Bytes (0.00%)
  • ui: 111 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [db9d7f3]
Page Load Metrics (1695 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15542179169114670
domContentLoaded15472083166513163
load15622186169514369
domInteractive15201514321
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 177 Bytes (0.00%)
  • ui: 111 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

dan437
dan437 reviewed Sep 24, 2024
View reviewed changes
test/e2e/tests/swaps/shared.ts Outdated Show resolved Hide resolved
test/e2e/mock-e2e.js Outdated Show resolved Hide resolved
test/e2e/tests/smart-transactions/mock-requests-for-swap-test.ts Outdated Show resolved Hide resolved
@dbrans dbrans requested review from a team as code owners September 24, 2024 10:51
dan437
dan437 previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@dan437 dan437 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [a203b50]
Page Load Metrics (1764 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint147623871767243117
domContentLoaded146823321744240115
load147623841764246118
domInteractive1410139199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 177 Bytes (0.00%)
  • ui: 111 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@dbrans dbrans enabled auto-merge October 14, 2024 01:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [5b0ecb8]
Page Load Metrics (2024 ± 114 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint170927642024256123
domContentLoaded169426731996238114
load170426882024238114
domInteractive15145523014

@dbrans dbrans added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 15, 2024
Merged via the queue into develop with commit 82e5a45 Oct 15, 2024
78 checks passed
@HowardBraham HowardBraham deleted the djb/stx-e2e branch October 15, 2024 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 15, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@jclancy93 jclancy93 jclancy93 approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@chloeYue chloeYue chloeYue left review comments

@dan437 dan437 dan437 left review comments

@vinnyhoward vinnyhoward vinnyhoward left review comments

Assignees
No one assigned
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-transactions Transactions team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@dbrans @metamaskbot @chloeYue @Gudahtt @jclancy93 @matthewwalsh0 @vinnyhoward @dan437 @HowardBraham @gauthierpetetin