addressing review comments

MetaMask · Sep 24, 2024 · 9fe15fe · 9fe15fe
1 parent be435a8
commit 9fe15fe
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 23 deletions.
diff --git a/test/e2e/mock-e2e.js b/test/e2e/mock-e2e.js
@@ -289,11 +289,6 @@ async function setupMocking(
             mobileActive: true,
             extensionActive: true,
           },
-          localhost: {
-            fallbackToV1: false,
-            mobileActive: true,
-            extensionActive: true,
-          },
           smartTransactions: {
             mobileActive: false,
             extensionActive: true,

diff --git a/test/e2e/tests/smart-transactions/mock-requests-for-swap-test.ts b/test/e2e/tests/smart-transactions/mock-requests-for-swap-test.ts
@@ -290,6 +290,17 @@ const GET_TRANSACTION_BY_HASH_RESPONSE = {
 export const mockSwapRequests = async (mockServer: MockttpServer) => {
   await mockEthDaiTrade(mockServer);
 
+  await mockServer
+    .forJsonRpcRequest({
+      method: 'eth_getBalance',
+      params: ['0x5cfe73b6021e818b776b421b1c4db2474086a7e1'],
+    })
+    .thenJson(200, {
+      id: 3806592044086814,
+      jsonrpc: '2.0',
+      result: '0x1bc16d674ec80000', // 2 ETH
+    });
+
   await mockServer
     .forPost('https://transaction.api.cx.metamask.io/networks/1/getFees')
     .withJsonBodyIncluding(GET_FEES_REQUEST_INCLUDES)
@@ -315,26 +326,13 @@ export const mockSwapRequests = async (mockServer: MockttpServer) => {
     .once()
     .thenJson(200, GET_BATCH_STATUS_RESPONSE_SUCCESS);
 
-  await mockServer
-    .forJsonRpcRequest({
-      method: 'eth_getBalance',
-      params: ['0x5cfe73b6021e818b776b421b1c4db2474086a7e1'],
-    })
-    // .once()
-    .thenJson(200, {
-      id: 3806592044086814,
-      jsonrpc: '2.0',
-      result: '0x1bc16d674ec80000', // 2 ETH
-    });
-
   await mockServer
     .forJsonRpcRequest({
       method: 'eth_getTransactionReceipt',
       params: [
         '0xec9d6214684d6dc191133ae4a7ec97db3e521fff9cfe5c4f48a84cb6c93a5fa5',
       ],
     })
-    // .once()
     .thenJson(200, GET_TRANSACTION_RECEIPT_RESPONSE);
 
   await mockServer
@@ -344,6 +342,5 @@ export const mockSwapRequests = async (mockServer: MockttpServer) => {
         '0xec9d6214684d6dc191133ae4a7ec97db3e521fff9cfe5c4f48a84cb6c93a5fa5',
       ],
     })
-    // .once()
     .thenJson(200, GET_TRANSACTION_BY_HASH_RESPONSE);
 };
diff --git a/test/e2e/tests/swaps/shared.ts b/test/e2e/tests/swaps/shared.ts
@@ -95,10 +95,6 @@ export const reviewQuote = async (
     '[data-testid="exchange-rate-display-quote-rate"]',
   );
   const summaryText = await summary.getText();
-  console.log('============\nsummaryText\n============', {
-    summaryText,
-    options,
-  });
   assert.equal(summaryText.includes(options.swapFrom), true);
   assert.equal(summaryText.includes(options.swapTo), true);
   const quote = summaryText.split(`\n`);