Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test Request Queuing for Multiple Dapps and Txs on different networks should batch confirmation txs for different dapps on different networks. #27095

Merged
merged 1 commit into from
Sep 12, 2024
+5 −13
Merged

fix: flaky test Request Queuing for Multiple Dapps and Txs on different networks should batch confirmation txs for different dapps on different networks. #27095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions test/e2e/tests/request-queuing/batch-txs-per-dapp-diff-network.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { strict: assert } = require('assert');
const { By } = require('selenium-webdriver');
const FixtureBuilder = require('../../fixture-builder');
const {
withFixtures,
Expand Down Expand Up @@ -124,14 +124,10 @@ describe('Request Queuing for Multiple Dapps and Txs on different networks', fun

await switchToNotificationWindow(driver, 4);

let navigationElement = await driver.findElement(
'.confirm-page-container-navigation',
await driver.findElement(
By.xpath("//div[normalize-space(.)='1 of 2']"),
);

let navigationText = await navigationElement.getText();

assert.equal(navigationText.includes('1 of 2'), true);

// Check correct network on confirm tx.
await driver.findElement({
css: '[data-testid="network-display"]',
Expand All @@ -149,14 +145,10 @@ describe('Request Queuing for Multiple Dapps and Txs on different networks', fun
// Wait for new confirmations queued from second dapp to open
await switchToNotificationWindow(driver, 4);

navigationElement = await driver.findElement(
'.confirm-page-container-navigation',
await driver.findElement(
By.xpath("//div[normalize-space(.)='1 of 2']"),
);

navigationText = await navigationElement.getText();

assert.equal(navigationText.includes('1 of 2'), true);

// Check correct network on confirm tx.
await driver.findElement({
css: '[data-testid="network-display"]',
Expand Down