fix: flaky test Request Queuing for Multiple Dapps and Txs on different networks should batch confirmation txs for different dapps on different networks.

[seaona]

Description

In this test, there is an anti-pattern, where we first find an element and then assert its inner value. This is a source of flakiness, since at the moment we assert the value, it could be that it doesn't have the expected value yet, making the assertion to fail.

let navigationElement = await driver.findElement(
  '.confirm-page-container-navigation',
);
let navigationText = await navigationElement.getText();
assert.equal(navigationText.includes('1 of 2'), true);

Instead of this, we should try to directly find the element by its value. This ensures that we wait until the element has the right value.

Note: in this case, since the value is broken down, we find the value by the xpath.

Related issues

Fixes: #26933

Manual testing steps

1. Check ci

Screenshots/Recordings

Above

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [82ec20f]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1728 ± 115 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	310	2343	1664	386	185
		domContentLoaded	1449	2320	1710	227	109
		load	1457	2404	1728	240	115
		domInteractive	12	120	39	24	12

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)