-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: MMI adds back the current Tx confirmation view to MMI #26539
Merged
zone-live
merged 12 commits into
develop
from
MMI-5392-revert-new-confirmations-ui-to-current
Aug 27, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
53135ea
chore: wip
zone-live 217dd16
chore: adds back the current UI for MMI
zone-live fde615b
chore: better yet
zone-live 6f6a575
chore: update and lint
zone-live 4d3f859
chore: update and lint
zone-live 567318f
chore: update code fences
zone-live 90495fa
chore: test update
zone-live cc79b12
chore: prettier
zone-live cfc91f6
Merge branch 'develop' into MMI-5392-revert-new-confirmations-ui-to-c…
zone-live 4843b8f
chore: adds isMMI method approach
zone-live 6e148ae
chore: clean up
zone-live 7428e1e
chore: update test while at it
zone-live File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewwalsh0 This seems to be the logical place for what you suggested, already does it for the beta build type. I'm not adding a code fence for this since it would mean that an other one would have to exist on the
useCurrentConfirmation
hook (otherwise things break), also it would add unnecessary complexity imo and this can be useful down the road for similar cases.