chore: MMI adds back the current Tx confirmation view to MMI #26539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [567318f]
Page Load Metrics (78 ± 13 ms)
Bundle size diffs
|
Builds ready [cfc91f6]
Page Load Metrics (84 ± 14 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26539 +/- ##
===========================================
+ Coverage 70.02% 70.04% +0.02%
===========================================
Files 1408 1411 +3
Lines 49105 49209 +104
Branches 13735 13756 +21
===========================================
+ Hits 34383 34466 +83
- Misses 14722 14743 +21 ☔ View full report in Codecov by Sentry. |
matthewwalsh0
requested changes
Aug 22, 2024
zone-live
commented
Aug 22, 2024
| @@ -31,6 +31,10 @@ export function isBeta() { | |||
| return process.env.METAMASK_BUILD_TYPE === 'beta'; | |||
| } | |||
|
|
|||
| export function isMMI() { | |||
There was a problem hiding this comment.
@matthewwalsh0 This seems to be the logical place for what you suggested, already does it for the beta build type. I'm not adding a code fence for this since it would mean that an other one would have to exist on the useCurrentConfirmation hook (otherwise things break), also it would add unnecessary complexity imo and this can be useful down the road for similar cases.
Builds ready [6e148ae]
Page Load Metrics (77 ± 10 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Builds ready [7428e1e]
Page Load Metrics (79 ± 8 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
approved these changes
Aug 27, 2024
shane-t
approved these changes
Aug 27, 2024
metamaskbot
added
the
release-12.5.0
gauthierpetetin
added
release-12.4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While we don't support the new confirmation UI for Txs (MMI flow got broken with the upgrade), we need to show the current one to MMI.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist