Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pass along hashed rpcUrl during CustomNetworkAdded event #26203

Merged
merged 8 commits into from
Jul 30, 2024
Merged

chore: Pass along hashed rpcUrl during CustomNetworkAdded event #26203

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
851aaea
Pass along hashed rpcUrl along in sensitive properties of trackEvent …
gambinish Jul 29, 2024
b19a793
Update hashing method to call more generic hash utils in shared modules
gambinish Jul 29, 2024
42c129e
Merge branch 'develop' into chore/mmassets-298_capture-custom-rpc-url
gambinish Jul 30, 2024
02212a3
Merge branch 'develop' into chore/mmassets-298_capture-custom-rpc-url
gambinish Jul 30, 2024
7bc258d
Update ui/pages/settings/networks-tab/networks-form/networks-form.js
gambinish Jul 30, 2024
6e23452
Merge branch 'develop' into chore/mmassets-298_capture-custom-rpc-url
gambinish Jul 30, 2024
8eea39d
Merge branch 'chore/mmassets-298_capture-custom-rpc-url' of github.co…
gambinish Jul 30, 2024
1e05cac
trigger build
gambinish Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ui/pages/settings/networks-tab/networks-form/networks-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ import {
import { getLocalNetworkMenuRedesignFeatureFlag } from '../../../../helpers/utils/feature-flags';
import { ACTION_MODES } from '../../../../components/multichain/network-list-menu/network-list-menu';
import InfoTooltip from '../../../../components/ui/info-tooltip';
import { sha256 } from '../../../../../shared/modules/hash.utils';

/**
* Attempts to convert the given chainId to a decimal string, for display
Expand Down Expand Up @@ -968,6 +969,9 @@ const NetworksForm = ({
MetaMetricsNetworkEventSource.CustomNetworkForm,
token_symbol: ticker,
},
sensitiveProperties: {
rpcUrl: await sha256(rpcUrl),
},
});
if (networkMenuRedesign) {
dispatch(
Expand Down