-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Pass along hashed rpcUrl
during CustomNetworkAdded
event
#26203
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Co-authored-by: Brian Bergeron <[email protected]>
…m:MetaMask/metamask-extension into chore/mmassets-298_capture-custom-rpc-url
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26203 +/- ##
========================================
Coverage 69.96% 69.96%
========================================
Files 1411 1411
Lines 49946 49946
Branches 13805 13805
========================================
Hits 34942 34942
Misses 15004 15004 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Builds ready [8eea39d]
Page Load Metrics (333 ± 304 ms)
Bundle size diffs
|
Builds ready [1e05cac]
Page Load Metrics (348 ± 314 ms)
Bundle size diffs
|
Description
Pass along hashed
rpcUrl
when added as a custom network. We are hashing the rpcUrl for privacy reasons, so that no customrpcUrls
get leaked. For instance, this would be important for those running their own ETH nodes.When leveraging this new value, analytics should also hash
rpcUrls
of common rpc's on chainlist, then compare the hashes. Note that I opted not to use theURL
constructor, since it will enforce trailing/
on base urls when I am noticing that most urls onchainlist
do not have this: https://chainlist.org/chain/1Related issues
Fixes: MMASSETS-298 mobile PR also needs to be added.
Manual testing steps
Add CustomNetwork and ensure that the proper payload is sent in the network tab when
CustomNetworkAdded
event fires off.Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist